Fix: Typescript Type Definition for Configuration.Options.secure_distribution type - Githubissues

cloudinary / pkg-cloudinary-core

Distribution repository for the Cloudinary JavaScript library. Cloudinary is an end-to-end solution for all your image and video needs.

MIT License

54 stars 28 forks source link

Fix: Typescript Type Definition for Configuration.Options.secure_distribution type #27

Open seibert-io opened 5 years ago

seibert-io commented 5 years ago

The Type definition for Configuration.Options.secure_distribution is wrong. Type definitions declare it as boolean | undefined https://github.com/cloudinary/pkg-cloudinary-core/blob/47ffb3b0c1a163fb1b4e2fc74931c1992a23122b/cloudinary-core.d.ts#L813, wheres Usage inline-docs and application behavior indicate it must be a string containing the cname to use, not just a boolean value.

See