search

cloudius-systems / mgmt

20 stars 11 forks source link

'arp' in CLI does not work #3

Open tzach opened 10 years ago

tzach commented 10 years ago

arp command appears in the help, but does not have a description, and does not seems to produce any output

lightpriest commented 10 years ago

Originally from here https://github.com/cloudius-systems/osv/blob/62f3e58d555b6a8d86bdade098e269f3ae80dbe2/console/arp.js Is it still needed?

tzach commented 10 years ago

It is, but lets document it, so it will be useful. Why did we removed it?

dorlaor commented 10 years ago

On Thu, Dec 12, 2013 at 11:38 AM, Tzach Livyatan notifications@github.comwrote:

It is, but lets document it, so it will be useful. Why did we removed it?

Initially we used it to set the networking but eventually we automated the arp entry addition. I started to think that normal OS usage won't be needing arp but OSv is a good candidate for low level virtual network function appliance and arp may be needed for it so I do vote the keep it

— Reply to this email directly or view it on GitHubhttps://github.com/cloudius-systems/mgmt/issues/3#issuecomment-30401729 .

lightpriest commented 10 years ago

It's not removed, the original JS code for it was removed in favor of the crash commands. I'll add description to the current command.

tzach commented 10 years ago

arp command still appears in help without description. Command it self does not work.

tzach commented 10 years ago

arp command in the cli cause a crash osv version: OSv v0.05-153-g6e87ff7 on Fedora 20

org.crsh.cli.impl.descriptor.IllegalValueTypeException: Type java.lang.Object is not handled at the moment
    at org.crsh.cli.impl.ParameterType.create(ParameterType.java:80)
    at org.crsh.cli.impl.lang.CommandFactory.create(CommandFactory.java:128)
    at org.crsh.cli.impl.lang.CommandFactory.create(CommandFactory.java:221)
    at org.crsh.cli.impl.lang.CommandFactory.commands(CommandFactory.java:85)
    at org.crsh.cli.impl.lang.CommandFactory.create(CommandFactory.java:99)
    at org.crsh.command.BaseShellCommand.<init>(BaseShellCommand.java:63)
    at org.crsh.lang.groovy.GroovyCommandManager.make(GroovyCommandManager.java:258)
    at org.crsh.lang.groovy.GroovyCommandManager.access$100(GroovyCommandManager.java:60)
    at org.crsh.lang.groovy.GroovyCommandManager$1.getCommand(GroovyCommandManager.java:242)
    at org.crsh.shell.impl.command.CRaSH.getCommand(CRaSH.java:103)
    at org.crsh.shell.impl.command.CRaSHSession.getCommand(CRaSHSession.java:93)
    at org.crsh.lang.script.PipeLineFactory.create(PipeLineFactory.java:75)
    at org.crsh.lang.script.ScriptREPL.eval(ScriptREPL.java:64)
    at org.crsh.shell.impl.command.CRaSHSession.createProcess(CRaSHSession.java:180)
    at org.crsh.shell.impl.async.AsyncProcess.execute(AsyncProcess.java:139)
    at org.crsh.processor.jline.JLineProcessor.loop(JLineProcessor.java:328)
    at org.crsh.processor.jline.JLineProcessor.run(JLineProcessor.java:273)
    at org.crsh.standalone.CRaSH.main(CRaSH.java:381)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.crsh.cli.impl.lang.MethodDescriptor$1.invoke(MethodDescriptor.java:189)
    at org.crsh.cli.impl.invocation.InvocationMatch.invoke(InvocationMatch.java:106)
    at org.crsh.cli.impl.invocation.InvocationMatch.invoke(InvocationMatch.java:100)
    at org.crsh.cli.impl.bootstrap.Main.handle(Main.java:62)
    at org.crsh.cli.impl.bootstrap.Main.main(Main.java:52)
    at com.cloudius.cli.Main.main(Main.java:6)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at io.osv.RunJava.runMain(RunJava.java:152)
    at io.osv.RunJava$1.run(RunJava.java:123)
    at io.osv.OsvSystemClassLoader$1.run(OsvSystemClassLoader.java:70)
lightpriest commented 10 years ago

Weird. This happened to me because parameter didn't have types (and return type was Object). Are you sure you're testing with the latest version of mgmt? https://github.com/cloudius-systems/mgmt/blob/master/crash/src/main/resources/crash/commands/cloudius/arp.groovy

tzach commented 10 years ago

Good guess :) I was working on the latest osv, which is not the latest mgmt - as would any user do. We should bump up the mgmt version on the osv git