search

cloudius-systems / osv

OSv, a new operating system for the cloud.
osv.io
Other
4.1k stars 603 forks source link

ELF Loader loads a module which is on excluding list #594

Open orumin opened 9 years ago

orumin commented 9 years ago

In core/elf.cc: program::program(), provides list what OSv supplied.

If library which is on the list are uploaded to OSv image, OSv loads that.

This commit is avoid this problem at -100,13 +61,12 https://github.com/cloudius-systems/osv-apps/commit/70ea5778bdddd8a8dfa12af84b2076779d7e725a?diff=unified

nyh commented 9 years ago

On Thu, Feb 19, 2015 at 5:03 PM, orumin notifications@github.com wrote:

In core/elf.cc: program::program(), provides list what OSv supplied.

If library which is on the list are uploaded to OSv image, OSv loads that.

This commit is avoid this problem at -100,13 +61,12 cloudius-systems/osv-apps@70ea577?diff=unified https://github.com/cloudius-systems/osv-apps/commit/70ea5778bdddd8a8dfa12af84b2076779d7e725a?diff=unified

I did not understand what bug you're reporting here...

Is the bug that elf.cc's "supplied_modules" list does not work, and the loader tries to load libresolv.so.2 from the filesystem?

Or is the bug the fact that we upload this file was unnecessarily, though harmless?

orumin commented 9 years ago

Sorry, I'm poor at English

yes, elf.cc's "supplied_modules" list does not work. loader tries to load libresolv.so.2 from the filesystem if it available.

syuu1228 commented 9 years ago

We've found that when libresolv.so.2 mistakenly copied on the filesystem, ELF loader loads that. Even it's on supplied_modules. Minoru deleted libresolv.so.2 from usr.manifest on recent patch, but it seems we should not allow to load it.

wkozaczuk commented 5 years ago

I wonder if this is still an issue. I am not even sure what the issue is.