DefaultVersionFinder fail to find dash included version scheme.

cloudmatrix / esky

an auto-update framework for frozen python apps

BSD 3-Clause "New" or "Revised" License

362 stars 74 forks source link

Closed fingul closed 10 years ago

fingul commented 10 years ago

DefaultVersionFinder fail to find dash included version scheme. ex) v1.1-2-3

IMHO, omit escaping in regular expression.

current (https://github.com/cloudmatrix/esky/blob/master/esky/finder.py#L177) version_re = "[a-zA-Z0-9\\.-_]+"
fix version_re = "[a-zA-Z0-9\\.\\-_]+"

rfk commented 10 years ago