search

cloudmatrix / esky

an auto-update framework for frozen python apps
BSD 3-Clause "New" or "Revised" License
362 stars 74 forks source link

find_versions improvement request #75

Closed stephanelsmith closed 9 years ago

stephanelsmith commented 9 years ago

Url's are not required to have quotes, see: https://developers.google.com/speed/pagespeed/module/filter-quote-remove

This breaks find_version regular expression which requires quote. link_re = "href='\"['\"]" % (filename_re,)

recommended fix making quotes optional:

link_re = "href=['\"]?(?P([^'\"]*/)?%s)['\"]?" % (filename_re,)

Commit coming....

stephanelsmith commented 9 years ago

An example, current expectation is file name is surrounded by ", eg. xxxx-0.0.17.win32.zip

However, this is valid html syntax as well. xxxx-0.0.17.win32.zip

Suggesting updating regex as mentioned above.

rfk commented 9 years ago

Fixed by #76