search

cloudmesh-community / book

Gregor von Laszewski
https://cloudmesh-community.github.io/
26 stars 106 forks source link

Chapter: Puppet #272

Open tandon-ritz opened 5 years ago

tandon-ritz commented 5 years ago

hid-sp18-520 https://github.com/cloudmesh-community/book/blob/master/chapters/devops/puppet.md

Please provide push access to below directory so that I can upload files for puppet paper-

laszewsk commented 5 years ago

you need to provide an alternate directory and make sure the urls are readable, than TAs can copy them into

devops/images

tandon-ritz commented 5 years ago

Following are links to images from original repo used in puppet tutorial.

https://github.com/cloudmesh-community/hid-sp18-520/blob/master/tutorial/Images/IAC.jpg

https://github.com/cloudmesh-community/hid-sp18-520/blob/master/tutorial/Images/master-slave-connection.jpg

https://github.com/cloudmesh-community/hid-sp18-520/blob/master/tutorial/Images/master-slave.jpg

https://github.com/cloudmesh-community/hid-sp18-520/blob/master/tutorial/Images/master-slave1.jpg

https://github.com/cloudmesh-community/hid-sp18-520/blob/master/tutorial/Images/push-pull-configuration.jpg

I verified and tested that all urls works.

Thanks

laszewsk commented 5 years ago

images have been added.

you can use in document with images/name....

do not use https as this doe not work in epubs for images

laszewsk commented 5 years ago

once fully integrated, please remove puppet from your original repository, and make sure to update url in your README to the book url if not already done.

This prevents TAs to be confused and only review one source

laszewsk commented 5 years ago

All links specified are wrong and are not direct links to images. thus I committed the wrong content. the right images are for example:

https://github.com/cloudmesh-community/hid-sp18-520/raw/master/tutorial/Images/IAC.jpg

tandon-ritz commented 5 years ago

Thanks for updating images link. I can now see the images in md. Appreciate your help. For some reason when I copied original link from my colleague repo, it copied blob link.

laszewsk commented 5 years ago

Check out the draft ePub

E.g.

cd draft make make view or open the pub

On Jan 22, 2019, at 7:42 PM, Ritesh Tandon notifications@github.com wrote:

Thanks for updating images link. I can now see the images in md. Appreciate your help. For some reason when I copied original link from my colleague repo, it copied blob link.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cloudmesh-community/book/issues/272#issuecomment-456621614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ8VfO_c6XSKBj6kol9J6mtFZ9SyQ0Fks5vF6_kgaJpZM4aHCzs.

laszewsk commented 5 years ago

Bo, please review