This PR moves key generation from the config command to the key command. It also removes the EncryptFile class.
There are two primary reasons for the migration. First, even though the config does use a specific type of key it makes more sense to ensure that all key related commands are hosted under one class. Second, the key command uses the new KeyHandler class for generation and verification whereas the old cms config key related commands used the EncryptFile class. The EncryptFile class is removed since its purpose has been subsumed by the new CmsEncryptor and KeyHandler classes.
The test_encryption.py file was removed for two reasons. First, encryption related test files are already included in cms-configuration. Second, the cms-cloud oved since it was only testing the incorrectly implemented EncryptFile.
This PR moves key generation from the
configcommand to thekeycommand. It also removes the EncryptFile class.There are two primary reasons for the migration. First, even though the config does use a specific type of key it makes more sense to ensure that all key related commands are hosted under one class. Second, the
keycommand uses the new KeyHandler class for generation and verification whereas the oldcms configkey related commands used the EncryptFile class. The EncryptFile class is removed since its purpose has been subsumed by the new CmsEncryptor and KeyHandler classes.The test_encryption.py file was removed for two reasons. First, encryption related test files are already included in cms-configuration. Second, the cms-cloud oved since it was only testing the incorrectly implemented EncryptFile.
The complementary cloudmesh-manual PR should be approved in conjunction with this PR.