cloudmesh / cloudmesh-cloud

Multicloud Cloudmesh Plugins for cloudmesh cmd5 CMD
https://cloudmesh.github.io/cloudmesh-manual
Apache License 2.0
2 stars 27 forks source link

AWS, oracle: verify pytest for secgroup #293

Open laszewsk opened 4 years ago

laszewsk commented 4 years ago

there is some information in the provider test for sec group why doe sthis matter, shoudl the sec groups not just work, if this is important i think it shoudl be explained somewhere

    if cloud == 'aws':
        group_indicator = 'GroupName'
    elif cloud == 'oracle':
        group_indicator = '_display_name'
    # elif cloud == 'chameleon':
    else:
        group_indicator = 'name'

    for e in sec_groups:
        print(e[group_indicator])
laszewsk commented 4 years ago

This has been fixed in oracle but not yet in aws:

https://github.com/cloudmesh/cloudmesh-oracle/pull/5

laszewsk commented 4 years ago

The modification in the cloudmesh-cloud/tests is not yet done even for oracle

nirandaperera commented 4 years ago

I dont quite understand what you mean by this. But I the tests are passing for both aws and azure