cloudmesh / cloudmesh-pi-burn

Burns many SD cards so we can build a Raspberry PI cluster
Other
18 stars 12 forks source link

Fix Windows wifi finder and getpass #64

Closed jpfleischer closed 2 years ago

jpfleischer commented 2 years ago

fix burn.py 554 it is convoluted if ssid is not specified, then probe it first. if it is specified on the CLI then use it. if the ssid returns as None, just interrupt (return "") but before, do Console.error('Cannot detect SSID. Please specify it via CLI with --ssid=SSID')

the next thing has to do with the wifi password, which follows the same process as SSID. if password is specified, then use it. if its not specified, use getpass. or your windows method.

(when executed on dks computer, the echo command printed the password in cleartext.)

getpass implementation required

implement getpass for windows just as we have get_ssid

we need a general getpass function that works on windows, linux, raspberry pi, mac. we use this function instead of having this complicated function (if windows and gitbash then do echo) it should be in a function so we can put it into common cloudmesh.common.util.getpass have you typed in the correct password? retype it for security reasons