search

cloudmesh / cloudmesh-rest

experimental REST services with eve
Other
0 stars 8 forks source link

fix:usr: updated mongo.py file #4

Closed satyamsah closed 7 years ago

satyamsah commented 7 years ago

fix:usr: added delete function code added nosetest code for in main method added some code for rubustness added try -except blocks in mongo.py flie

laszewsk commented 7 years ago

you need to put a subject on your commits you only added the metadata

laszewsk commented 7 years ago

I integrated some of the changes, but did significant improvements so i had to reject your pull request:

a) introduced global parameters to allow future mods with config file integration b) inroduce a log print to remove past copy programming style and make the code more readable c) used proper comments under methods to include parameters in the documentation d) fix all indentation whichis still not right in your last pull request e) use Shell from cloudmesh_client as we do not want to reinvent the whele and we have used this now for years. Also se taht we can not use commands: Deprecated since version 2.6: The commands module has been removed in Python 3.

Please rebase or fork new and start improving from there