cloudml / zen

Zen aims to provide the largest scale and the most efficient machine learning platform on top of Spark, including but not limited to logistic regression, latent dirichilet allocation, factorization machines and DNN.
Apache License 2.0
170 stars 75 forks source link

(FM/MVM, etc.) FM is controlled by zen.lda.numPartitions #52

Open benmccann opened 8 years ago

benmccann commented 8 years ago

To change the number of partitions in FM you have to set zen.lda.numPartitions. It's strange FM is controlled by LDA configuration. Perhaps this config property should be renamed to not include LDA in the name or a second configuration property should be introduced for FM?

FM.initializeDataSet calls DBHPartitioner.partitionByDBH which references LDADefines.cs_numPartitions which is defined as zen.lda.numPartitions.