cloudnative-pg / charts

CloudNativePG Helm Charts
Apache License 2.0
138 stars 62 forks source link

Add support for more kinds of recovery targets #272

Open gpothier opened 2 months ago

gpothier commented 2 months ago

It is not currently possible to specify any type of recoveryTarget other than targetTime in the cluster bootstrap:

    {{- with .Values.recovery.pitrTarget.time }}
    recoveryTarget:
      targetTime: {{ . }}
    {{- end }}

What is your feeling about breaking changes*? I would suggest this:

    {{- with .Values.recovery.recoveryTarget }}
    recoveryTarget:
      {{- toYaml . | nindent 6 }}
    {{- end }}

Which means that:

*Actually, it is actually simple to maintain backward compatibility if needed: instead of replacing the first snippet by the second one, we could keep both.

What do you think? Would you take a PR for this change?

itay-grudev commented 1 month ago

I originally wanted to keep it simple, but I'm accepting PRs for this.