search

cloudnative-pg / charts

CloudNativePG Helm Charts
Apache License 2.0
174 stars 82 forks source link

Add walStorage capability and remove gkeEnvironment conflict in cluster chart. #312

Closed rocket357 closed 3 months ago

rocket357 commented 3 months ago

The operator supports walStorage, but the chart does not (yet). This PR fixes that.

In addition, this PR addresses issue https://github.com/cloudnative-pg/charts/issues/311 so gkeEnvironment can be set without the operator admission webhook rejecting the update.

rocket357 commented 3 months ago

I'm working on an additional chart issue (https://github.com/cloudnative-pg/charts/issues/311) where having gkeEnvironment set to true causes the admission webhook in the operator to reject updates (due to applicationCredentials being also set). I've rolled that change in here as well. If it's preferred for me to break these out into separate PRs, please let me know!

itay-grudev commented 3 months ago

@rocket357 Not everyone would approve, but the PR is so tiny - I'm fine with it as is. Just make sure both issues are mentioned in the PR description.

rocket357 commented 3 months ago

Requested changes have been added. Please let me know if there's anything else that needs to be updated!