Add selector to Deployment spec in helm templates

cloudnativedevops / demo

Simple demonstration app for 'Cloud Native Devops'

MIT License

799 stars 517 forks source link

Add selector to Deployment spec in helm templates #17

Closed domingusj closed 4 years ago

domingusj commented 4 years ago

As @tobinus pointed out in https://github.com/cloudnativedevops/demo/issues/16 the newer Deployments are failing when installing with helm with the following error:

Error: release demo failed: Deployment.apps "demo" is invalid: [spec.selector: Required value, spec.template.metadata.labels: Invalid value: map[string]string{"app":"demo", "environment":"development"}: `selector` does not match template `labels`]

This PR adds the missing selector section.

bitfield commented 4 years ago

What was the Kubernetes release which introduced this problem? And what was the specific change? The Deployment schema?

domingusj commented 4 years ago

@bitfield pretty sure it was the jump in API version from this change: https://github.com/cloudnativedevops/demo/pull/15