search

cloudnativegeo / cloud-optimized-geospatial-formats-guide

https://guide.cloudnativegeo.org
Creative Commons Attribution 4.0 International
121 stars 17 forks source link

Add notebook for LAS to COPC Conversion #109

Closed omshinde closed 3 months ago

omshinde commented 4 months ago

Ref https://github.com/cloudnativegeo/cloud-optimized-geospatial-formats-guide/issues/107 Tutorial for converting LiDAR LAS files to COPC format using PDAL -

Dataset used - G-LiHT Lidar Point Cloud V001

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

wildintellect commented 4 months ago

A few minor comments on the notebook itself. Bigger picture I think we need to hit all the core topics. Looking at https://guide.cloudnativegeo.org/cloud-optimized-geotiffs/cogs-examples.html creation (command line) and metadata but not actual cloud-optimized usage. Comparing that to https://guide.cloudnativegeo.org/zarr/zarr-in-practice.html which creates, explores, and demos access. This might be a follow up ticket related to #91 but I would consider adding simple usage to this example.

omshinde commented 4 months ago

Thanks @wildintellect

A few minor comments on the notebook itself. Bigger picture I think we need to hit all the core topics. Looking at https://guide.cloudnativegeo.org/cloud-optimized-geotiffs/cogs-examples.html creation (command line) and metadata but not actual cloud-optimized usage. Comparing that to https://guide.cloudnativegeo.org/zarr/zarr-in-practice.html which creates, explores, and demos access. This might be a follow up ticket related to https://github.com/cloudnativegeo/cloud-optimized-geospatial-formats-guide/issues/91 but I would consider adding simple usage to this example.

Those are great suggestions. I can add another intro notebook focusing only on accessing a LAS file and displaying metadata using PDAL (no COPC details). Then this notebook would serve the COPC creation, access and getting point cloud stats.

omshinde commented 3 months ago

@wildintellect can you please add @jsignell as a reviewer for this PR. Thank you.

omshinde commented 3 months ago

Thanks @jsignell for the comprehensive review. I've updated the notebook addressing your comments. Requesting re-review.

wildintellect commented 3 months ago

@omshinde you're missing the navigation in https://github.com/cloudnativegeo/cloud-optimized-geospatial-formats-guide/blob/8ff9f5f9339e65b1139b8751dc4348b4fe342ec8/_quarto.yml#L54-L55

omshinde commented 3 months ago

Thanks @wildintellect ..updated the navigation link