cloudnativegeo / cloud-optimized-geospatial-formats-guide

https://guide.cloudnativegeo.org
Creative Commons Attribution 4.0 International
121 stars 17 forks source link

Previews Broken for PRs originating in Forks #74

Closed wildintellect closed 8 months ago

wildintellect commented 9 months ago

This is probably a permissions/security problem related to not previewing content generated outside of the main fork. https://github.com/cloudnativegeo/cloud-optimized-geospatial-formats-guide/actions/runs/6354887466/job/17262077823?pr=73

TODO: research the github recommended solution for how to deal with this. I know I've seen it written about before.

Acceptance Criteria

wildintellect commented 9 months ago

Research:

pull_request_target seems to be the answer but there are deep security implications. Need to read through how to properly protect the repository.

wildintellect commented 9 months ago

The github action we're using does not support forks yet.

This Action does not currently support deploying previews for PRs from forks, but will do so in https://github.com/rossjrw/pr-preview-action/pull/6.

zacharyDez commented 8 months ago

I propose the following workaround to integrate external forks in the meantime that we decide on another solution: