Feat/cog overviews

[wildintellect]

New notebook showing an in-depth comparison of overview resampling methods.

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

kylebarron commented on 2023-11-13T22:41:22Z ----------------------------------------------------------------

Maybe add a hyperlink to titiler?

Upper case GDAL in "available in gdal"?

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

kylebarron commented on 2023-11-13T22:41:23Z ----------------------------------------------------------------

You say "The original file does not contain overviews" but it shows IFDs 1, 2, and 3 have positive decimations...? I thought that meant this file does contain some overviews.

wildintellect commented on 2023-11-13T23:31:00Z ----------------------------------------------------------------

Oh, right since I changed the example file to an updated one that's actually a COG. I suppose I can just drop that part of the sentence.

wildintellect commented on 2023-11-15T00:50:14Z ----------------------------------------------------------------

reworded

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

kylebarron commented on 2023-11-13T22:41:24Z ----------------------------------------------------------------

Line #6.    OverviewResampling = [r for r in ResamplingEnums if (r.value < 8) or r.value > 13]

I think this is pretty hard for someone to follow because they have to know the specific ordering of items in ResamplingEnum as well as what those mean. Even if it's verbose, I'd suggest having a more literal list like just

resample_methods = [
    Resampling.nearest,
    Resampling.bilinear,
    ...
] 

wildintellect commented on 2023-11-13T23:35:14Z ----------------------------------------------------------------

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

kylebarron commented on 2023-11-13T23:42:53Z ----------------------------------------------------------------

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

wildintellect commented 7 months ago

Oh, right since I changed the example file to an updated one that's actually a COG. I suppose I can just drop that part of the sentence.

---

View entire conversation on ReviewNB

wildintellect commented 7 months ago

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

---

View entire conversation on ReviewNB

kylebarron commented 7 months ago

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

--- View entire conversation on ReviewNB

wildintellect commented 7 months ago

reworded

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

kylebarron commented on 2023-11-13T22:41:23Z ----------------------------------------------------------------

You say "The original file does not contain overviews" but it shows IFDs 1, 2, and 3 have positive decimations...? I thought that meant this file does contain some overviews.

wildintellect commented on 2023-11-13T23:31:00Z ----------------------------------------------------------------

Oh, right since I changed the example file to an updated one that's actually a COG. I suppose I can just drop that part of the sentence.

wildintellect commented on 2023-11-15T00:50:14Z ----------------------------------------------------------------

reworded

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

kylebarron commented on 2023-11-13T22:41:24Z ----------------------------------------------------------------

Line #6.    OverviewResampling = [r for r in ResamplingEnums if (r.value < 8) or r.value > 13]

I think this is pretty hard for someone to follow because they have to know the specific ordering of items in ResamplingEnum as well as what those mean. Even if it's verbose, I'd suggest having a more literal list like just

resample_methods = [
    Resampling.nearest,
    Resampling.bilinear,
    ...
] 

wildintellect commented on 2023-11-13T23:35:14Z ----------------------------------------------------------------

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

kylebarron commented on 2023-11-13T23:42:53Z ----------------------------------------------------------------

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

wildintellect commented 7 months ago

Oh, right since I changed the example file to an updated one that's actually a COG. I suppose I can just drop that part of the sentence.

---

View entire conversation on ReviewNB

wildintellect commented 7 months ago

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

---

View entire conversation on ReviewNB

kylebarron commented 7 months ago

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

--- View entire conversation on ReviewNB

wildintellect commented 7 months ago

reworded

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

kylebarron commented on 2023-11-13T22:41:24Z ----------------------------------------------------------------

Line #6.    OverviewResampling = [r for r in ResamplingEnums if (r.value < 8) or r.value > 13]

I think this is pretty hard for someone to follow because they have to know the specific ordering of items in ResamplingEnum as well as what those mean. Even if it's verbose, I'd suggest having a more literal list like just

resample_methods = [
    Resampling.nearest,
    Resampling.bilinear,
    ...
] 

wildintellect commented on 2023-11-13T23:35:14Z ----------------------------------------------------------------

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

kylebarron commented on 2023-11-13T23:42:53Z ----------------------------------------------------------------

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

wildintellect commented 7 months ago

Oh, right since I changed the example file to an updated one that's actually a COG. I suppose I can just drop that part of the sentence.

---

View entire conversation on ReviewNB

wildintellect commented 7 months ago

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

---

View entire conversation on ReviewNB

kylebarron commented 7 months ago

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

--- View entire conversation on ReviewNB

wildintellect commented 7 months ago

reworded

---

View entire conversation on ReviewNB

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[wildintellect]

Oh, right since I changed the example file to an updated one that's actually a COG. I suppose I can just drop that part of the sentence.

---

View entire conversation on ReviewNB

[wildintellect]

It's dynamic though, if/when GDAL adds more options they automatically are part of the list(which did happen during the original implementation of this code), assuming GDAL doesn't change the order. I'll think about how to simplfy, thanks.

---

View entire conversation on ReviewNB

[kylebarron]

I think as long as you don't exclude by number, it'll read more clearly. How about:

from rasterio.enums import Resampling

excluded_resamplings = {
    Resampling.max,
    Resampling.min,
    Resampling.med,
    Resampling.q1,
    Resampling.q3,
}
resample_methods = [
    method for method in Resampling if method not in excluded_resamplings
]
resample_methods
# [<Resampling.nearest: 0>,
#  <Resampling.bilinear: 1>,
#  <Resampling.cubic: 2>,
#  <Resampling.cubic_spline: 3>,
#  <Resampling.lanczos: 4>,
#  <Resampling.average: 5>,
#  <Resampling.mode: 6>,
#  <Resampling.gauss: 7>,
#  <Resampling.sum: 13>,
#  <Resampling.rms: 14>]

--- View entire conversation on ReviewNB

[wildintellect]

reworded

---

View entire conversation on ReviewNB