search

cloudnativelabs / kube-shell

Kubernetes shell: An integrated shell for working with the Kubernetes
Apache License 2.0
2.38k stars 174 forks source link

Specify yaml.FullLoader in yaml.load_all statement #75

Closed madmatt112 closed 2 years ago

madmatt112 commented 4 years ago

Currently, running kube-shell shows a PyYAML Loader deprecation warning because the yaml Loader type isn't specified in two "yaml.load_all" calls.
As per PyYAML documentation, after showing the warning, PyYAML defaults to using the FullLoader.
This change explicitly sets the FullLoader, which will suppress the error in a non-future-breaking way - that is, if a future PyYAML version exits instead of warning & defaulting when a Loader type is not specified.

Fixes #71 Fixes #73

Signed off by: Matthew Field fieldm58@gmail.com

madmatt112 commented 2 years ago

Is this project still maintained?

madmatt112 commented 2 years ago

Abandoning this PR. Project doesn't seem active.