search

cloudnc / ngx-sub-form

Utility library for breaking down an Angular form into multiple components
https://cloudnc.github.io/ngx-sub-form
MIT License
314 stars 33 forks source link

Angular 8 branch #151

Closed ntziolis closed 3 years ago

ntziolis commented 4 years ago

It be great to have a dedicated branch for angular 8 to be able to pull request to it as upgrading existing projects is not always feasible immediately. Not intending for you to actively maintain an angular 8 version, but this would let folks create PRs and keep it somewhat up to date.

The angular 8 version would be kept at v4. Any PR (usually these should be cherry picks from the master) could not introduce breaking changes only minor or patch.

As you can imagine I'm keep to get the typings into the v4 version, even if you are not going to create an angular 8 branch I would appreciate if you could cherry pick my PR into the v4 version :)

maxime1992 commented 4 years ago

Yes I do totally agree 👍 I talked about it with @zakhenry few weeks ago before making the upgrade to ng9 but never took the time to make it happens. I think I can set this up pretty easily so I'll give it a go soon

maxime1992 commented 4 years ago

I'm guessing this is a bit late now that angular 11 is around the corner :sweat_smile:

@ntziolis I've learnt quite a few things about how to make that happens while working on the huge refactor that I've published as a pre release so doing that for other versions should be easier in the future :crossed_fingers:

Feel free to close this issue if you think it's a bit too late too and we'll try to do better next time! :angel:

maxime1992 commented 3 years ago

Closing as this doesn't seem to be needed.

Although as explained above, I think it should be pretty easy to do that next time we need it :+1: