search

cloudnc / ngx-sub-form

Utility library for breaking down an Angular form into multiple components
https://cloudnc.github.io/ngx-sub-form
MIT License
315 stars 33 forks source link

fix: CI #308

Closed erikmom closed 9 months ago

erikmom commented 9 months ago

@maxime1992 With help of a colleague, I got the Github action to work on my own fork (See https://github.com/erikmom/ngx-sub-form/actions/runs/7048769520).

ubuntu-20-10 does not seem to be available as runner on github. Changed it to ubuntu-latest and then it uses ubuntu20-4.

Also noticed now that I again had some issues with line endings on changed files. This commit also fixes that

maxime1992 commented 9 months ago

Brilliant, thanks a lot for digging into that.

The only thing would be, can you fix the version to use 20.04? That's what it was doing before I did attempt to change it as I thought it was needed to use 20.10. https://github.com/cloudnc/ngx-sub-form/commit/7957087b161e8f063bd61226f32e795c70b15ecb

But if it's not, I'd still rather have the exact version, it can save some troubles while debugging.

erikmom commented 9 months ago

Updated. Will it pick up the correct verion number? Or at least something v10+ ?

maxime1992 commented 9 months ago

Yes it should :) Thanks for the PR!

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 10.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: