cloudoperators / greenhouse-extensions

Extensions for Greenhouse, the cloud operations platform
Apache License 2.0
1 stars 2 forks source link

🐛 [BUG] kube-node-labels metricLabelsAllowlist not enabled in kube-state-metrics #382

Closed viennaa closed 1 week ago

viennaa commented 1 week ago

Priority

(Medium) I'm annoyed but I'll live

Description

kube_node_labels are not present in the current implementation and we need it for general alerting.

Figured out, when looking into ceph based alerting. Brought it in initially, but this needs to go to the generic chart too:

https://github.com/sapcc/helm-charts/commit/1e5f8f24f36f32f654b32b785c694feffa62becc

Reproduction steps

1. Prometheus instance of kube-monitoring
2. Query `kube_node_labels`; you won't see any

Screenshots

No response

viennaa commented 1 week ago

Cross checked and the needed configuration is correct. Also, they are pulled in correctly now. Closingg

Removing past commit:

https://github.com/sapcc/helm-charts/pull/7049