cloudoperators / greenhouse-extensions

Extensions for Greenhouse, the cloud operations platform
Apache License 2.0
2 stars 3 forks source link

[opentelemetry] Clean up of the helm values and structure #518

Closed olandr closed 1 day ago

olandr commented 6 days ago
olandr commented 4 days ago

Why do we need to add the monitoring CRDs here? Wouldn't they conflict with the CRDs provisioned via prometheus-operator? So unless you are deploying the operator too (which we are doing already in the alerts or kube-monitoring plugin), this is not needed.

I see. If it is a pre-condition that the prom-operator exists then ofc the CRD will not be needed. The way that I thought this plugin was progressing was unrelated to other plugins (i.e. that there was not a particular dependency tree between plugins).

I will make the README a bit more clear on the requirements here in that case, and remove the redundant CRDs.

viennaa commented 4 days ago

The way that I thought this plugin was progressing was unrelated to other plugins (i.e. that there was not a particular dependency tree between plugins).

Technically this is true. As stated earlier, the prometheus-operator needs to be there, to do something with the resources. If it is not around, we don't need them. As soon as it would be deployed in the cluster, this plugin would add the needed resources, since the condition (hasCapabilities) becomes true.

viennaa commented 4 days ago

Bump the minor version please.

Minor please, not patch :) https://semver.org/

timojohlo commented 1 day ago

Nice, first PR done I would say 👍