cloudoperators / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library
http://cloudoperators.github.io/juno/
Apache License 2.0
4 stars 0 forks source link

[Task](ui): Pagination fixes #328

Open edda opened 2 weeks ago

edda commented 2 weeks ago

Task Description Improvements for the Pagination component. There are various issues with the Pagination component due to the fact that internally it uses an uncontrolled Select in the select variant. This leads to unexpected behaviour when the initial props that are passed to the component change (e.g. because the total number of pages was retrieved asynchronously after the component was already rendered. To fix this we will use the Select in controlled mode and keep internal state in the Pagination component itself. This way it can by used like an uncontrolled or a controlled component. This will lead to less confusion for app developers.

Additionally add some extra features to the Pagination component: disabled state for the whole component, loading state Bug fix: input field width should be dynamic in case of huge numbers

Sub-tasks

Fixes:

MartinS-git commented 2 weeks ago

PR: https://github.com/cloudoperators/juno/pull/352 Please also close old PR: https://github.com/sapcc/juno/pull/564

MartinS-git commented 1 week ago

PR update