cloudoperators / juno

Monorepo for the Juno microfrontend framework, microfrontend apps, design system and component library

http://cloudoperators.github.io/juno/

Apache License 2.0

4 stars 0 forks source link

fix(supernova): errors from the silencesAPI are only parsed if they are not string #484

Closed TilmanHaupt closed 4 days ago

TilmanHaupt commented 5 days ago

fixes #474

Changes Made

Checks if error message is a string and not a object and does not parse if its a string.

Testing Instructions

npm i
npm run TASK

Checklist

[x] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[ ] I have made corresponding changes to the documentation (if applicable).
[x] My changes generate no new warnings or errors.

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: 1e0f6c587bffd906882acc399565fe84fd83165d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 5 days ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-01 14:01 UTC