cloudoperators / juno

Monorepo for the Juno modular frontend framework, apps, design system and component library
http://cloudoperators.github.io/juno/
Apache License 2.0
4 stars 0 forks source link

chore(ui): convert LoadingIndicator to Typescript #562

Closed guoda-puidokaite closed 2 weeks ago

guoda-puidokaite commented 3 weeks ago

Summary

Changes Made

TypeScript Migration:

Fixes/Improvements:

Testing:

Cleanup:

Documentation:

Screenshot: Deprecated .js code on the left, migrated .ts code on the right (see notes)

Screenshot 2024-10-25 at 09 14 09

Release:

Related Issues

Testing Instructions

  1. Run Storybook
  2. Run LoadingIndicator tests

Checklist

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 7bcc5336aa281fe79a858b14ed4d9bae82282199

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------------- | ----- | | @cloudoperators/juno-ui-components | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-25 09:33 UTC

guoda-puidokaite commented 2 weeks ago
ERROR in ./src/components/LoadingIndicator/LoadingIndicator.stories.tsx 5:0-46
Module not found: Error: Can't resolve './index.js' in '/Users/wowa/work/juno/packages/ui-components/src/components/LoadingIndicator'

Ooops, somehow missed to commit that file... Pushed now.