Closed guoda-puidokaite closed 2 weeks ago
Latest commit: 7bcc5336aa281fe79a858b14ed4d9bae82282199
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-25 09:33 UTC
ERROR in ./src/components/LoadingIndicator/LoadingIndicator.stories.tsx 5:0-46 Module not found: Error: Can't resolve './index.js' in '/Users/wowa/work/juno/packages/ui-components/src/components/LoadingIndicator'
Ooops, somehow missed to commit that file... Pushed now.
Summary
LoadingIndicator
component toTypeScript
, enhancing code quality, maintainability, and scalability.Changes Made
TypeScript Migration:
LoadingIndicator
component files toTypeScript
.Fixes/Improvements:
number
andstring
forsize
.size
, defaulting to size96
when an invalid number value (e.g. empty string),0
or a negative value is passed.StyleProvider
from ui-components/srcindex
file.Testing:
Storybook
.vitest
.Cleanup:
.js
components.Documentation:
Storybook
documentation.Screenshot: Deprecated
.js
code on the left, migrated.ts
code on the right (see notes)Release:
changeset
file, mentioning the migration and bug fix.Related Issues
Testing Instructions
Storybook
LoadingIndicator
testsChecklist