cloudoperators / juno

Monorepo for the Juno modular frontend framework, apps, design system and component library
http://cloudoperators.github.io/juno/
Apache License 2.0
4 stars 0 forks source link

chore(carbon): refactor layout to match current dashboard #564

Closed taymoor89 closed 1 month ago

taymoor89 commented 1 month ago

Summary

This PR refactors the side navigation and the general layout to match the current greenhouse dashboard.

Changes Made

Related Issues

Screenshots (if applicable)

Layout

Before:

Screenshot 2024-10-24 at 16 17 09

After:

Screenshot 2024-10-24 at 16 17 34

Side Navigation

Greenhouse greenhouse Carbon carbon

Testing Instructions

  1. cd apps/carbon
  2. npm i
  3. npm run dev

Checklist

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: ffb68db27ad896bd91d0ecef5c93f6e79de95550

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-28 09:02 UTC

andypf commented 1 month ago

It looks like this PR breaks the tests for Greenhouse. We should investigate and fix the issue.