Closed barsukov closed 1 week ago
Latest commit: fbbad56ae57f4e84ffcaf47b5f7fc32d71f2523e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-04 08:57 UTC
@guoda-puidokaite regarding export/import lets focus on migration make same way it iwas before then we would decide where we wanna go with it later with whoel project.
Yah, not a blocking change for this PR as I mentioned. 🤪 But wanted to bring it up and see what you think. We can talk about it in the future. 🚀
I really think that some change requests are good improvements, but others I would not mix up with migration. Migration is migration, we need to move trhough as carefull and quick as possible. Then later on we could be more dedicated on refactoring topics, but it is nice that you point some staff out @guoda-puidokaite
As mentioned, only the type addition boolean
change is a requested change. Rest I'm asking questions about, maybe some topics are worth bringing to the improvements EPIC. And some not. 😉🚀
Summary
Select
,SelectOption
,SelectDivider
components toTypeScript
Select
,SelectOption
,Changes Made
TypeScript Migration:
Select
,SelectOption
,SelectDivider
component files toTypeScript
.Select
,SelectOption
component forJavascript
files.SelectRow
componentRefactoring:
Testing:
AppShellProvider
component from tests and stories, as not yet converted. But replace it with PortalProvider cause it should be a more accurate use case, since stories use PortalProvider instead.Storybook
.vitest
.Release:
changeset
file.Related Issues
Testing Instructions
Storybook
Select
,SelectOption
,SelectDivider
testsChecklist