cloudoperators / juno

Monorepo for the Juno modular frontend framework, apps, design system and component library
http://cloudoperators.github.io/juno/
Apache License 2.0
4 stars 0 forks source link

chore(ui): migrate Select component to TypeScript #571

Closed barsukov closed 1 week ago

barsukov commented 2 weeks ago

Summary

Changes Made

TypeScript Migration:

Refactoring:

Testing:

Release:

Related Issues

Testing Instructions

  1. Run Storybook
  2. Run Select, SelectOption, SelectDivider tests

Checklist

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: fbbad56ae57f4e84ffcaf47b5f7fc32d71f2523e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------------- | ----- | | @cloudoperators/juno-ui-components | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 weeks ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-04 08:57 UTC

barsukov commented 2 weeks ago

@guoda-puidokaite regarding export/import lets focus on migration make same way it iwas before then we would decide where we wanna go with it later with whoel project.

guoda-puidokaite commented 2 weeks ago

Yah, not a blocking change for this PR as I mentioned. 🤪 But wanted to bring it up and see what you think. We can talk about it in the future. 🚀

barsukov commented 2 weeks ago

I really think that some change requests are good improvements, but others I would not mix up with migration. Migration is migration, we need to move trhough as carefull and quick as possible. Then later on we could be more dedicated on refactoring topics, but it is nice that you point some staff out @guoda-puidokaite

guoda-puidokaite commented 2 weeks ago

As mentioned, only the type addition boolean change is a requested change. Rest I'm asking questions about, maybe some topics are worth bringing to the improvements EPIC. And some not. 😉🚀