cloudoperators / juno

Monorepo for the Juno modular frontend framework, apps, design system and component library

http://cloudoperators.github.io/juno/

Apache License 2.0

4 stars 0 forks source link

chore(ui): migrate ComboBox component to typescript #589

Closed gjaskiewicz closed 1 week ago

gjaskiewicz commented 2 weeks ago

Summary

Migrate combobox to TypeScript

Changes Made

Migrate Combobox to TypeScript
Migrate ComboboxOption to TypeScript

Related Issues

Issue 1: [link to issue]

Testing Instructions

npm i
npm run storybook

Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have made corresponding changes to the documentation (if applicable).
[ ] My changes generate no new warnings or errors.

github-actions[bot] commented 2 weeks ago

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-18 13:11 UTC

barsukov commented 2 weeks ago

You delete everything where is the changes? :) I mean if it is a draft or not finished please close the PR

gjaskiewicz commented 2 weeks ago

@barsukov @guoda-puidokaite can you take a look?

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: c76db3c02a087f3b74ffd2de35c5f7ff75f9c9cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------------------------------- | ----- | | @cloudoperators/juno-ui-components | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

andypf commented 1 week ago

@gjaskiewicz Kindly address the issues identified by Guoda. It seems there are some regressions that need attention.

gjaskiewicz commented 1 week ago

(Blocking)

Discrepancies in Storybook (currently live on left, PR on right):

ComboBoxOption: children missing in props

ComboBox: Breaking type change? The updated type for helptext, errortext and successtext is more restrictive than ReactNode. Could these be breaking changes?

ComboBox: Are these function controls correct? Doesn't look right, but not sure. We didn't have any controls in the past. 🤷‍♀️

Before requesting another review, please double check that the old Storybook has no regressions. 🙏 It's difficult, as there's so many props in this one! But we can do it with few eyes on it. 👀

Checked storybook options one-by-one. Should be fine now.