File manager uploads to wrong site

[sorin-coza]

CloudPanel version(s) affected

2.4.1

Description

The file manager switches its context based on a cookie (I think?), so if a large upload is in progress in one site, and then we open a new browser window and go to another site's file manager, and assuming the upload finishes now, the file upload will be uploaded to this second site.

How to reproduce

• make sure you have 2 sites to manage in your CloudPanel
• open CloudPanel in 2 separate tabs
• go to first tab, select site1 and go to file manager and upload a larger file (10-20 MB at least)
• ( in order to have enough time, you can optionally slow down the network from Chrome dev tools > Network > Throttling )
• now, after your upload has begun in the first tab, go to the second tab, then select site2, and go to file manager. CloudPanel now thinks the user is working on site2, so the upload will be transferred to site2 when finished - it does not know that we started the upload on site1.
• wait for the upload to finish. (You can now reset the network if you slowed it down, so you don't wait forever... )
• the file will be uploaded to site2

I think this scenario is very realistic when someone manages multiple sites, and has to upload large files.

Possible Solution

Need to make the file manager aware of where the upload was first started.

Additional Context

No response

[cloudpanel-io]

Thanks for reporting it. We will check this in detail and get it fixed in the versions.