search

cloudpipe / cloudpickle

Extended pickling support for Python objects
Other
1.64k stars 167 forks source link

Run Dask's `test_pickle_empty` on CI again #442

Closed jakirkham closed 3 years ago

jakirkham commented 3 years ago

We needed to skip this in PR ( https://github.com/cloudpipe/cloudpickle/pull/432 ) as it was failing. This has since been fixed upstream ( https://github.com/dask/distributed/pull/5303 ). So readd testing of it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #442 (cc6c1a5) into master (ef6fb90) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files           4        4           
  Lines         720      720           
  Branches      150      150           
=======================================
  Hits          665      665           
  Misses         34       34           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ef6fb90...cc6c1a5. Read the comment docs.

jakirkham commented 3 years ago

Yep thanks Pierre πŸ˜„ Pushed an empty commit above

jakirkham commented 3 years ago

There was one more flaky test. Added that to skip list with a reference. Otherwise seems to be working πŸ™‚

pierreglaser commented 3 years ago

thank you very much @jakirkham for your support on the distributed-side of cloudpickle'CI!

jakirkham commented 3 years ago

Ofc thanks for your help as well, Pierre :)