search

cloudpipe / cloudpickle

Extended pickling support for Python objects
Other
1.64k stars 167 forks source link

pytest no longer bundles py #487

Closed frenzymadness closed 1 year ago

frenzymadness commented 1 year ago

py is kinda deprecated and pytest now bundles only a subset of it. It'd be best to stop depending on it. If it's not possible, dependency on py should be explicitly specified so the original package is installed.

https://github.com/cloudpipe/cloudpickle/blob/f5472e1a2eb4235e61b632b58367dede93dfb30c/tests/cloudpickle_test.py#L1472

stanislavlevin commented 1 year ago

https://docs.pytest.org/en/latest/changelog.html#pytest-7-2-0-2022-10-23:

#10396: pytest no longer depends on the py library. pytest provides a vendored copy of py.error and py.path modules but will use the py library if it is installed. If you need other py.* modules, continue to install the deprecated py library separately, otherwise it can usually be removed as a dependency.

The affected test of cloudpickle relies on py package that previously was indirectly pulled into tests environment as pytest's dependency.

frenzymadness commented 1 year ago

And it seems that it has been there only for Python 2 compatibility which is not available in py since 2019.

ogrisel commented 1 year ago

Thanks, this was fixed in #494.

ogrisel commented 1 year ago

And it seems that it has been there only for Python 2 compatibility which is not available in py since 2019.

I missed that. Feel free to open a follow-up PR to completely delete this test.