cloudpipe / cloudpickle

Extended pickling support for Python objects
Other
1.64k stars 167 forks source link

add black formatter #498

Closed Ali-RT closed 11 months ago

Ali-RT commented 1 year ago

In reference to issue #497, I created this PR.

rgbkrk commented 1 year ago

Would you be willing to do this over again / rebase? I'll be happy to review it now.

Ali-RT commented 1 year ago

Would you be willing to do this over again / rebase? I'll be happy to review it now.

rebased.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.21% and project coverage change: -0.42 :warning:

Comparison is base (a76f081) 83.28% compared to head (1f6d8b2) 82.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #498 +/- ## ========================================== - Coverage 83.28% 82.86% -0.42% ========================================== Files 4 4 Lines 718 718 Branches 157 157 ========================================== - Hits 598 595 -3 Misses 95 95 - Partials 25 28 +3 ``` | [Impacted Files](https://codecov.io/gh/cloudpipe/cloudpickle/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloudpipe) | Coverage Δ | | |---|---|---| | [cloudpickle/cloudpickle.py](https://codecov.io/gh/cloudpipe/cloudpickle/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloudpipe#diff-Y2xvdWRwaWNrbGUvY2xvdWRwaWNrbGUucHk=) | `76.12% <56.25%> (-0.27%)` | :arrow_down: | | [cloudpickle/cloudpickle\_fast.py](https://codecov.io/gh/cloudpipe/cloudpickle/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloudpipe#diff-Y2xvdWRwaWNrbGUvY2xvdWRwaWNrbGVfZmFzdC5weQ==) | `90.82% <84.00%> (-0.62%)` | :arrow_down: | | [cloudpickle/\_\_init\_\_.py](https://codecov.io/gh/cloudpipe/cloudpickle/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloudpipe#diff-Y2xvdWRwaWNrbGUvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloudpipe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cloudpipe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ogrisel commented 1 year ago

Personally I would be in favor of using ruff instead of flake8 and put both black and ruff in the pre-commit config and actually use the pre-commit run command on the CI to avoid having to duplicate the configuration.

ogrisel commented 11 months ago

Personally I would be in favor of using ruff instead of flake8 and put both black and ruff in the pre-commit config and actually use the pre-commit run command on the CI to avoid having to duplicate the configuration.

I just did that in #521.