search

cloudposse-archives / tfmask

Terraform utility to mask select output from `terraform plan` and `terraform apply`
https://cloudposse.com/accelerate
Apache License 2.0
202 stars 27 forks source link

Just mask with eight stars #10

Open brandonkal opened 4 years ago

brandonkal commented 4 years ago

Why is the length of a secret included in the output? It would be better to mask with a set length list of repeated characters.

osterman commented 4 years ago

I can see your point. In some ways it's perhaps more secure the conceal the length in addition to the characters. What I don't like about it is it conceals also bad values (e.g. empty strings or exceptionally short passwords).

I don't have a super strong opinion on this. If others would like it to work this way, wouldn't oppose a PR for it (ideally making it optional?).