search

cloudposse-archives / tfmask

Terraform utility to mask select output from `terraform plan` and `terraform apply`
https://cloudposse.com/accelerate
Apache License 2.0
202 stars 27 forks source link

Support attributes without quotes #20

Closed taurelius closed 4 years ago

taurelius commented 4 years ago

Adds support for masking resource attributes in the formats value : "secret" and value = "secret".

I've had to update the default values regex for this to prevent the terraform tests from matching on the id in override_special.

Thanks @eversC for your help on this one!

taurelius commented 4 years ago

@osterman Sorry to tag you directly, any chance you'd be able to take a look at this for me this week?

eversC commented 4 years ago

Hi @osterman, please could we get this reviewed? This fixes masking for resource types that we're using in our Org, and we'd much rather use your code/releases than fork.

fwiw we ran the /tests and diffed the outputs to check it looks okay.

osterman commented 4 years ago

Sorry - I get lost in notifications from github with 300+ repos. Best way to escalate is to ping me on slack.

@aknysh can you help with this?