search

cloudposse / bastion

🔒Secure Bastion implemented as Docker Container running Alpine Linux with Google Authenticator & DUO MFA support
https://cloudposse.com/accelerate
Apache License 2.0
640 stars 112 forks source link

Adding CloudFormation on ECS example #78

Closed jonmchan closed 1 year ago

jonmchan commented 1 year ago

Closes #24

max-lobur commented 1 year ago

I need to test this in AWS before merge

jonmchan commented 1 year ago

I would argue that we commit the documentation as is letting people know that this is just an example and we don't maintain these examples. I don't think it would be any more out of date than https://github.com/cloudposse/bastion/tree/main/examples/compose. The docker-compose file in there is still set to version 2! I would be surprised if https://github.com/cloudposse/bastion/tree/main/examples/compose still works straight out of the box.

max-lobur commented 1 year ago

Validated with https://www.cloudformation-validator.com/ ✅

max-lobur commented 1 year ago

I would argue that we commit the documentation as is letting people know that this is just an example and we don't maintain these examples. I don't think it would be any more out of date than https://github.com/cloudposse/bastion/tree/main/examples/compose. The docker-compose file in there is still set to version 2! I would be surprised if https://github.com/cloudposse/bastion/tree/main/examples/compose still works straight out of the box.

Agreed