[monochart] Update `envFrom` - Githubissues

cloudposse / charts

The "Cloud Posse" Distribution of Kubernetes Applications

https://cloudposse.com/accelerate

Apache License 2.0

158 stars 63 forks source link

[monochart] Update `envFrom` #253

Closed aknysh closed 4 years ago

aknysh commented 4 years ago

what

Update envFrom section in _helpers.tpl

why

envFrom is a list of EnvFromSource and there could be only one envFrom in a Container spec (possibly with many configMapRef and secretRef parameters)
The current implementation creates two envFrom sections, which is not correct behavior and will fail if we use these two configs at the same time:

envFrom:
  secrets:
    - secret-1
  configMaps:
    - config-1

and

secrets:
  default:
    enabled: true
    mountPath: /secret-default
    annotations:
      test.secret.annotation: value
    labels:
      test_label: value
    env:
      SECRET_ENV_NAME: ENV_VALUE
    files:
      secret.test.txt: |-
        some text

This update puts all configMapRef and secretRef parameters into just one envFrom section