cloudposse / geodesic

🚀 Geodesic is a DevOps Linux Toolbox in Docker
https://cloudposse.com/accelerate
Apache License 2.0
929 stars 117 forks source link

Add OCI annotations #917

Closed Nuru closed 5 months ago

Nuru commented 5 months ago

what

why

references

arcaven commented 5 months ago
michael@seki geodesic-cp % uname -a
Darwin seki 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64
michael@seki geodesic-cp % git fetch
...
michael@seki geodesic-cp % git checkout oci-labels
make all | tee oci-labels-build.txt
...
Step 18/86 : ENV GEODESIC_OS=debian
 ---> Using cache
 ---> 88ed1bcaefc4
Step 19/86 : ARG TARGETARCH
 ---> Running in bcdd94688c5c
Removing intermediate container bcdd94688c5c
 ---> 755e2ea071de
Step 20/86 : ARG TARGETOS
 ---> Running in 74c5cf99f11a
Removing intermediate container 74c5cf99f11a
 ---> b7a850c2cf2e
Step 21/86 : RUN [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)
 ---> Running in edfd0e580eac
Unsupported TARGETARCH: ""
The command '/bin/sh -c [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)' returned a non-zero code: 1
make[2]: *** [docker/build] Error 1
make[1]: *** [docker:build] Error 2
make: *** [debian.build] Error 2
michael@seki geodesic-cp %

Fixes are in #915

arcaven commented 5 months ago
michael@seki geodesic-cp % uname -a
Darwin seki 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64
michael@seki geodesic-cp % git fetch
...
michael@seki geodesic-cp % git checkout oci-labels
make all | tee oci-labels-build.txt
...
Step 18/86 : ENV GEODESIC_OS=debian
 ---> Using cache
 ---> 88ed1bcaefc4
Step 19/86 : ARG TARGETARCH
 ---> Running in bcdd94688c5c
Removing intermediate container bcdd94688c5c
 ---> 755e2ea071de
Step 20/86 : ARG TARGETOS
 ---> Running in 74c5cf99f11a
Removing intermediate container 74c5cf99f11a
 ---> b7a850c2cf2e
Step 21/86 : RUN [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)
 ---> Running in edfd0e580eac
Unsupported TARGETARCH: ""
The command '/bin/sh -c [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)' returned a non-zero code: 1
make[2]: *** [docker/build] Error 1
make[1]: *** [docker:build] Error 2
make: *** [debian.build] Error 2
michael@seki geodesic-cp %

Fixes are in #915

Although I like your code a lot more

Nuru commented 5 months ago

@arcaven Generally, people do not need to build Geodesic itself, so we are going to require buildkit to build it. I added an error message.