Open osterman opened 6 years ago
CI/CD is still broken. While the root cause was fixed, looks like the code is no longer vetted =)
https://travis-ci.org/cloudposse/github-authorized-keys/builds/402672514#L863
Open a new PR to fix the code so it passes CI/CD and results in a successful build.
@osterman issue still exists in go/vet target approach.
So we couldn't use constructions like $(GO) vet -v package1/file.go package2/file1.go
like in example with
find . ! -path "*/vendor/*" ! -path "*/.glide/*" -type f -name '*.go' | xargs $(GO) tool vet -v
, because it require that files to be from the same package.
So code vetting require all project structure with dependencies. Most common use case that i found is
$(GO) vet -v ./...
It recursively vetting project code and ignores folders started with .
and _
.
I think we should switch to this approach in build harness
what
why
references