search

cloudposse / terraform-aws-acm-request-certificate

Terraform module to request an ACM certificate for a domain name and create a CNAME record in the DNS zone to complete certificate validation
https://cloudposse.com/accelerate
Apache License 2.0
106 stars 69 forks source link

fix spilt of root domain #68

Closed shovelwagon closed 1 year ago

shovelwagon commented 1 year ago

what

This fixes what was mentioned in - https://github.com/cloudposse/terraform-aws-acm-request-certificate/pull/66

why

Adding a simple length check to where domains get update in an array fixes the mentioned issue.

  Error: no matching Route53Zone found

    with module.acm_request_certificate.data.aws_route53_zone.default["io"],
    on .terraform/modules/acm_request_certificate/main.tf line 38, in data "aws_route53_zone" "default":
    38: data "aws_route53_zone" "default" {

references

aknysh commented 1 year ago

@shovelwagon thanks for the PR.

Please run terraform fmt to format the code.

Also, please run these commands and commit the changes:

make init
make github/init
make readme
shovelwagon commented 1 year ago

@shovelwagon thanks for the PR.

Please run terraform fmt to format the code.

Also, please run these commands and commit the changes:

make init
make github/init
make readme

@aknysh, done!

aknysh commented 1 year ago

/test all