Removing target group from http_redirect listener rule

cloudposse / terraform-aws-alb

Terraform module to provision a standard ALB for HTTP/HTTP traffic

https://cloudposse.com/accelerate

Apache License 2.0

113 stars 122 forks source link

Removing target group from http_redirect listener rule #155

Closed mission-ajennings closed 7 months ago

mission-ajennings commented 8 months ago

what

Removed the target group from being added to http_redirect aws_lb_listener rule.

why

This creates a warning on the latest version of AWS Provider (5.35.0) and will eventually cause an error.

references

Commit to the provider that causes this warning
closes #154

joe-niland commented 8 months ago

Hi @mission-ajennings Thanks for your contribution.

It seems the readme is out of date. Could you please run the following and commit the result?

make init
make github/init
make readme

mission-ajennings commented 8 months ago

Hi @mission-ajennings Thanks for your contribution.

It seems the readme is out of date. Could you please run the following and commit the result?
make init
make github/init
make readme

thanks @joe-niland new readme pushed

hans-d commented 8 months ago

/terratest

joe-niland commented 7 months ago

@mission-ajennings apologies, the template has changed recently. Would you mind repeating that?

mergify[bot] commented 7 months ago

This pull request is now in conflict. Could you fix it @mission-ajennings? 🙏

mergify[bot] commented 7 months ago

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] commented 7 months ago

Thanks @mission-ajennings for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

osterman commented 7 months ago

@mission-ajennings we're looking into why mergify commented after it was closed. It was closed though due to 30 days inactivity, defined as no new commits. Please re-open if it's still something you can help fix.