Closed pm-trey closed 1 year ago
@pm-trey Hello. Thanks for your contribution.
Can we make github_token_type
as a variable with the default value of PLAINTEXT
?
Does it make sense to have github_token_type
PARAMETER_STORE
in some usecases?
/test all
/test all
@goruha We can, but there will be a bit more modification needed since the Codepipeline resource is expecting a plaintext value.
action {
name = "Source"
category = "Source"
owner = "ThirdParty"
provider = "GitHub"
version = "1"
output_artifacts = ["code"]
configuration = {
OAuthToken = var.github_oauth_token
Owner = var.repo_owner
Repo = var.repo_name
Branch = var.branch
PollForSourceChanges = var.poll_source_changes
}
}
I will add the ability for the token to be pulled from Parameter Store or Secrets Manager if those types are provided. That will allow the downstream codebuild module to work while providing a plaintext value to codepipeline Github source.
/terratest
what
why
references
Closes #107