cloudposse / terraform-aws-cloudfront-cdn

Terraform Module that implements a CloudFront Distribution (CDN) for a custom origin.
https://cloudposse.com/accelerate
Apache License 2.0
99 stars 121 forks source link

feat: allow providing whitelisted cookie names for ordered_cache_behavior #109

Closed rcmorano closed 6 months ago

rcmorano commented 1 year ago

what

This PR enables the module to provide whitelisted cookie names for ordered cache behaviors.

why

It was possible to provide all or none for the cookie forwarding attribute, but it wasn't possible to specify whitelist along with a list of cookie names.

hans-d commented 8 months ago

@rcmorano can you see if you can fix failing checks? Some involve reform and.or running some indicated make targets.

hans-d commented 8 months ago

/terratest

mergify[bot] commented 8 months ago

Thanks @rcmorano for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

hans-d commented 8 months ago

/terratest

mergify[bot] commented 6 months ago

💥 This pull request now has conflicts. Could you fix it @rcmorano? 🙏

mergify[bot] commented 6 months ago

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.