search

cloudposse / terraform-aws-cloudfront-cdn

Terraform Module that implements a CloudFront Distribution (CDN) for a custom origin.
https://cloudposse.com/accelerate
Apache License 2.0
99 stars 121 forks source link

Adding cache_policy_id to default and ordered behaviours #57

Closed justnom closed 3 years ago

justnom commented 3 years ago

what

why

references

jamengual commented 3 years ago

/test all

justnom commented 3 years ago

Thanks @jamengual. I just fixed the issue in d62bef6. Will the tests run automatically?

jamengual commented 3 years ago

/test all

justnom commented 3 years ago

@jamengual

Seems terratest is failing due to another unrelated issue.

jamengual commented 3 years ago

/test all

jamengual commented 3 years ago

/test all

jamengual commented 3 years ago

/test all

joe-niland commented 3 years ago

@jamengual looks like the logs bucket is not getting deleted by aws-nuke. I noticed the module allows specifying log_bucket_fqdn so perhaps it can be created externally with a random name for this test?

joe-niland commented 3 years ago

/test terratest

joe-niland commented 3 years ago

Added PR #58 which should fix the issue with tests. Once that is merged, this one should be OK.

joe-niland commented 3 years ago

/test all

joe-niland commented 3 years ago

@justnom thank you for your contribution!