search

cloudposse / terraform-aws-cloudfront-cdn

Terraform Module that implements a CloudFront Distribution (CDN) for a custom origin.
https://cloudposse.com/accelerate
Apache License 2.0
99 stars 121 forks source link

Adding custom_origins variable #61

Closed justnom closed 3 years ago

justnom commented 3 years ago

what

why

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @justnom? 🙏

nitrocode commented 3 years ago

/test all

justnom commented 3 years ago

@nitrocode Could I please get another test on this? Thanks!

joe-niland commented 3 years ago

/test all

jamengual commented 3 years ago

can you you run make readme @justnom

justnom commented 3 years ago

@jamengual Done!

I also fixed the behaviour for the forwarded_values in https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/61/commits/92ba01b40d99618ab6a3343de99825086f4ca6cf, I hope this isn't overkill. I wanted to deal with both empty strings and null values.

jamengual commented 3 years ago

/test all