cloudposse / terraform-aws-cloudfront-cdn

Terraform Module that implements a CloudFront Distribution (CDN) for a custom origin.
https://cloudposse.com/accelerate
Apache License 2.0
99 stars 121 forks source link

Add missing inputs to the wordpress example #62

Closed evertonevaristo closed 3 years ago

evertonevaristo commented 3 years ago

There are two missing properties in the locals dict,

cache_policy_id             = ""
origin_request_policy_id    = ""

what

why

references

nitrocode commented 3 years ago

/test all

nitrocode commented 3 years ago

What are you trying to fix here? Is the example not working?

Do you mind filling out the what and the why in the PR template ? These explanations help give us some context.

evertonevaristo commented 3 years ago

what The example script will work as expected.

why There's a lack of two parameters in the wordpress example...

cache_policy_id             = ""
origin_request_policy_id    = ""
evertonevaristo commented 3 years ago

What are you trying to fix here? Is the example not working?

Do you mind filling out the what and the why in the PR template ? These explanations help give us some context.

Yes! the example isnt working... (it's my first commit on a public repo, so.. I'm really newbie on this...)