cloudposse / terraform-aws-cloudfront-cdn

Terraform Module that implements a CloudFront Distribution (CDN) for a custom origin.
https://cloudposse.com/accelerate
Apache License 2.0
99 stars 121 forks source link

Upgrade S3 Log Storage module to latest version #97

Closed danfsd closed 1 year ago

danfsd commented 1 year ago

what

why

references

N/A

danfsd commented 1 year ago

Okay, I'm fairly new to the Cloudposse's community, but I think the game plan should be:

  1. Release a new version of terraform-aws-s3-bucket with https://github.com/cloudposse/terraform-aws-s3-bucket/pull/177 in it
  2. Release a new version of terraform-aws-s3-log-storage pointing to the new version for terraform-aws-s3-bucket
  3. Modify this PR by pointing to the new version of terraform-aws-s3-log-storage

What do you guys think?

danfsd commented 1 year ago

Actually, there was already an existing PR for fixing terraform-aws-s3-bucket https://github.com/cloudposse/terraform-aws-s3-bucket/pull/176

The game plan should not change and we can continue when either one of them gets merged.

max-lobur commented 1 year ago

Updating in https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/103