search

cloudposse / terraform-aws-cloudfront-s3-cdn

Terraform module to easily provision CloudFront CDN backed by an S3 origin
https://cloudposse.com/accelerate
Apache License 2.0
278 stars 247 forks source link

Fix S3 bucket error #282

Closed sebnapo closed 8 months ago

sebnapo commented 1 year ago

what

Be able to create a public S3 bucket

why

AWS added security enhancement regarding S3 bucket and by default they are private now. We need to add variables in order to make S3 bucket public for this module.

aknysh commented 1 year ago

/terratest

mergify[bot] commented 8 months ago

Thanks @sebnapo for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] commented 8 months ago

This pull request now has conflicts. Could you fix it @sebnapo? 🙏

mergify[bot] commented 8 months ago

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.