Add custom policies - Githubissues

cloudposse / terraform-aws-cloudtrail-s3-bucket

S3 bucket with built in IAM policy to allow CloudTrail logs

https://cloudposse.com/accelerate

Apache License 2.0

56 stars 60 forks source link

Closed bkero closed 3 years ago

bkero commented 3 years ago

Allows the policy variable to be used in a useful way to set a custom S3 bucket policy
Conditionally the data resource for the unused default bucket policy

Issue #19 outlines why this is required
I have tested this change and found it to sufficiently create a custom S3 bucket policy sufficient for oganization-level writing.

Closes #19

nitrocode commented 3 years ago

Could we use something like source_json instead of this ?

bkero commented 3 years ago

Could

I've added a commit to rework this as you advise.

jamengual commented 3 years ago

/test all

jamengual commented 3 years ago

/test all

jamengual commented 3 years ago

/test all