search

cloudposse / terraform-aws-dms

Terraform modules for provisioning and managing AWS DMS resources
https://cloudposse.com/accelerate
Apache License 2.0
7 stars 7 forks source link

DMS Endpoint add support for the s3_settings attribute use_task_start_time_for_full_load_timestamp #29

Closed finchr closed 3 months ago

finchr commented 3 months ago

Describe the Feature

the dms-endpoint module is missing the s3_settings attribute use_task_start_time_for_full_load_timestamp.

Expected Behavior

when I set 

use_task_start_time_for_full_load_timestamp = true

the resultling resource attribute is set to true and not false.

Use Case

This setting is required by DataBricks.

Describe Ideal Solution

Support for this attribute is added to the module.

Alternatives Considered

Deprecate s3_settings from aws_dms_endpoint and configure a aws_dms_s3_endpoint.

Additional Context

I'll have a PR for this submitted soon.