Optional private subnet creation

cloudposse / terraform-aws-dynamic-subnets

Terraform module for public and private subnets provisioning in existing VPC

https://cloudposse.com/accelerate

Apache License 2.0

197 stars 167 forks source link

Optional private subnet creation #127

Closed alexjurkiewicz closed 3 years ago

alexjurkiewicz commented 3 years ago

what

Add var.create_public_subnets and var.create_private_subnets

why

Sometimes you only want one of these subnet types
The module will always still reserve space in the CIDR block for both subnet types, so if you initially deploy only private subnets, you can enable public subnets later without affecting your existing private subnets.

alexjurkiewicz commented 3 years ago

Thanks for the feedback. Agreed on all points and updated.

I'll add some tests if you agree with the design 👍

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @alexjurkiewicz? 🙏

alexjurkiewicz commented 3 years ago

ping 🙏

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @alexjurkiewicz? 🙏

Nuru commented 3 years ago

@alexjurkiewicz Please remove the option to create only private subnets.

Remove the variable create_public_subnets/public_subnets_enabled.
Fix the NAT creation flag to suppress NATs when private_subnets_enabled is false.

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @alexjurkiewicz? 🙏

alexjurkiewicz commented 3 years ago

I am not deploying our private subnets with this module any more. For the record, we created private subnets for data lake-related services which should not access the internet.